Fixed terms visualization on mweb android #41234

samilabud · 2024-04-29T17:05:29Z

Details

We are using embedded content (OnFido) to load the terms, this comes with iframes that are out of our control, the first iframe comes with a height of 100% this is the root cause of why the content of the first iframe (the terms) is the only visible thing here, this is the cause of the double scroll bar.

We should use Javascript to get the viewPortHeight when the page load, later select the first iframe (the terms content) and specify the 80% of the getted height and set this one to the mentioned iframe, this modification should be done in Onfido component

Fixed Issues

$ #40941
PROPOSAL: #40941 (comment)

Tests

Go to Workspace > Workflows > Connect bank account
Select "Connect manually" and use the testing routing number and account number
On Personal info page, enter "First" and "Last" for first name and last name
Enter any other information on the rest of the Personal info pages and confirm
On the Onfido terms page, verify the "Accept" and "Do not accept" buttons are not visible at first glance
Scroll down the text to the bottom, verify that the buttons are not visible yet
Scroll down the page by scrolling from the bottom of the page (under the text)
Verify the buttons are now visible.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Go to Workspace > Workflows > Connect bank account
Select "Connect manually" and use the testing routing number and account number
On Personal info page, enter "First" and "Last" for first name and last name
Enter any other information on the rest of the Personal info pages and confirm
On the Onfido terms page, verify the "Accept" and "Do not accept" buttons are not visible at first glance
Scroll down the text to the bottom, verify that the buttons are not visible yet
Scroll down the page by scrolling from the bottom of the page (under the text)
Verify the buttons are now visible.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A (Terms are viewed in external website)

Android: mWeb Chrome

Android.Chrome.terms.test.mp4

iOS: Native

N/A (Terms are viewed in external website)

iOS: mWeb Safari

Iphone.Safari.terms.test.mp4

MacOS: Chrome / Safari

MAC.Chrome.Terms.test.mp4

MacOS: Desktop

MAC.Desktop.terms.test.mp4

mananjadhav · 2024-05-01T19:47:42Z

The change looks good. @luacmartins Can you trigger an adhoc build here so that I can test on a physical Android device?

luacmartins · 2024-05-01T20:01:36Z

Running https://github.com/Expensify/App/actions/runs/8914299434

github-actions · 2024-05-01T20:22:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41234/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41234/NewExpensify.dmg	https://41234.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mananjadhav · 2024-05-02T14:30:32Z

src/components/Onfido/index.tsx

+            const fidoRef = baseOnfidoRef.current;
+            if (fidoRef) {
+                // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+                const onfidoSdk = fidoRef.querySelector('#onfido-sdk > iframe') as HTMLElement | null;


@samilabud I think we should add a comment on why this code exists.

mananjadhav · 2024-05-02T15:14:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-onfido.mov

Android: mWeb Chrome

mweb-chrome-onfido-ba-buttons.mp4

iOS: Native

ios-onfido.mov

iOS: mWeb Safari

mweb-safari-onfido-ba-buttons.mov

MacOS: Chrome / Safari

web-onfido-ba-buttons.mov

MacOS: Desktop

desktop-onfido-ba-buttons_wDDre0Hn.mp4

mananjadhav · 2024-05-02T15:58:28Z

Just one thing on adding a comment. Rest all looks good.

samilabud · 2024-05-02T17:07:04Z

Just one thing on adding a comment. Rest all looks good.

Thanks for checking out, the comment was added, please verify 🙏🏼

mananjadhav

LGTM. @luacmartins All yours.

OSBotify · 2024-05-02T18:44:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:11:01Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fixed terms visualization on mweb android

a7bbd9b

samilabud requested a review from a team as a code owner April 29, 2024 17:05

melvin-bot bot requested review from MonilBhavsar and removed request for a team April 29, 2024 17:05

This comment was marked as outdated.

Sign in to view

MonilBhavsar requested review from mananjadhav and removed request for MonilBhavsar April 29, 2024 17:15

luacmartins added the Ready To Build label May 1, 2024

mananjadhav reviewed May 2, 2024

View reviewed changes

mananjadhav approved these changes May 2, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins May 2, 2024 15:58

samilabud added 2 commits May 2, 2024 12:55

Merge branch 'main' into fix_terms_fido_iframe_40941

56285d9

Added comment to explain the why of this change

cbb9fe5

mananjadhav approved these changes May 2, 2024

View reviewed changes

luacmartins approved these changes May 2, 2024

View reviewed changes

luacmartins merged commit ed3b427 into Expensify:main May 2, 2024
16 checks passed

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

lanitochka17 mentioned this pull request May 8, 2024

[HOLD for payment 2024-06-13] [$250] Connect Bank account - Background is slightly touching "Numbers" in Onfido Flow #41851

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed terms visualization on mweb android #41234

Fixed terms visualization on mweb android #41234

samilabud commented Apr 29, 2024 •

edited by luacmartins

Loading

This comment was marked as outdated.

mananjadhav commented May 1, 2024

luacmartins commented May 1, 2024

github-actions bot commented May 1, 2024

mananjadhav May 2, 2024

mananjadhav commented May 2, 2024 •

edited

Loading

mananjadhav commented May 2, 2024

samilabud commented May 2, 2024

mananjadhav left a comment

OSBotify commented May 2, 2024

OSBotify commented May 9, 2024

Fixed terms visualization on mweb android #41234

Fixed terms visualization on mweb android #41234

Conversation

samilabud commented Apr 29, 2024 • edited by luacmartins Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment was marked as outdated.

mananjadhav commented May 1, 2024

luacmartins commented May 1, 2024

github-actions bot commented May 1, 2024

mananjadhav May 2, 2024

Choose a reason for hiding this comment

mananjadhav commented May 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented May 2, 2024

samilabud commented May 2, 2024

mananjadhav left a comment

Choose a reason for hiding this comment

OSBotify commented May 2, 2024

OSBotify commented May 9, 2024

samilabud commented Apr 29, 2024 •

edited by luacmartins

Loading

mananjadhav commented May 2, 2024 •

edited

Loading